[kernel-spark] Add rate limiting to getFileChanges() for DSv2 streaming #5361
+220
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zikangh
changed the title
zikangh
changed the title
|
Hi @huan233usc @gengliangwang @tdas @jerrypeng could you please review this PR? |
gengliangwang
approved these changes
Oct 21, 2025
huan233usc
reviewed
Oct 21, 2025
|
|
||
| /** | ||
| * Interface for files that can be admitted by admission control in Delta streaming sources. | ||
| * This abstraction allows both Scala and Java IndexedFile implementations to be used with |
There was a problem hiding this comment.
nit: Scala and Java -> v1 and v2
huan233usc
reviewed
Oct 21, 2025
|
|
||
| /** | ||
| * Returns the size of the file in bytes. | ||
| * For files without a file action or files with unknown size, returns 0. |
There was a problem hiding this comment.
Can we just make this api can only be called when file action exists?
V1's current impl will just throw NPE if hasFileAction() is false
huan233usc
reviewed
Oct 27, 2025
|
|
||
| @Override | ||
| public long getFileSize() { | ||
| return addFile.getSize(); |
huan233usc
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
This PR is adds rate limiting to getFileChange() which reads delta metadata to determines what data to process (offset management).
How was this patch tested?
Parameterized tests verifying parity between DSv1 (DeltaSource) and DSv2 (SparkMicroBatchStream).
Does this PR introduce any user-facing changes?
No